[Python-checkins] cpython (3.2): #14179: add tests for re.compile. Patch by Florian Mladitsch.

ezio.melotti python-checkins at python.org
Tue Mar 13 00:33:50 CET 2012


http://hg.python.org/cpython/rev/fafe12f2a030
changeset:   75565:fafe12f2a030
branch:      3.2
parent:      75559:368a5d7d8a15
user:        Ezio Melotti <ezio.melotti at gmail.com>
date:        Tue Mar 13 01:29:48 2012 +0200
summary:
  #14179: add tests for re.compile.  Patch by Florian Mladitsch.

files:
  Lib/test/test_re.py |  10 ++++++++++
  Misc/ACKS           |   1 +
  2 files changed, 11 insertions(+), 0 deletions(-)


diff --git a/Lib/test/test_re.py b/Lib/test/test_re.py
--- a/Lib/test/test_re.py
+++ b/Lib/test/test_re.py
@@ -818,6 +818,16 @@
         self.assertRaises(OverflowError, _sre.compile, "abc", 0, [long_overflow])
         self.assertRaises(TypeError, _sre.compile, {}, 0, [])
 
+    def test_compile(self):
+        # Test return value when given string and pattern as parameter
+        pattern = re.compile('random pattern')
+        self.assertIsInstance(pattern, re._pattern_type)
+        same_pattern = re.compile(pattern)
+        self.assertIsInstance(same_pattern, re._pattern_type)
+        self.assertIs(same_pattern, pattern)
+        # Test behaviour when not given a string or pattern as parameter
+        self.assertRaises(TypeError, re.compile, 0)
+
 def run_re_tests():
     from test.re_tests import tests, SUCCEED, FAIL, SYNTAX_ERROR
     if verbose:
diff --git a/Misc/ACKS b/Misc/ACKS
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -629,6 +629,7 @@
 Andrii V. Mishkovskyi
 Dustin J. Mitchell
 Dom Mitchell
+Florian Mladitsch
 Doug Moen
 The Dragon De Monsyne
 Skip Montanaro

-- 
Repository URL: http://hg.python.org/cpython


More information about the Python-checkins mailing list