[Python-checkins] cpython (2.7): 2.7 - Issue #10484: Fix the CGIHTTPServer's PATH_INFO handling problem

senthil.kumaran python-checkins at python.org
Fri Mar 16 09:15:33 CET 2012


http://hg.python.org/cpython/rev/bab9f29c93fd
changeset:   75726:bab9f29c93fd
branch:      2.7
parent:      75710:6ce4868861ba
user:        Senthil Kumaran <senthil at uthcode.com>
date:        Fri Mar 16 01:07:16 2012 -0700
summary:
  2.7 - Issue #10484: Fix the CGIHTTPServer's PATH_INFO handling problem

files:
  Lib/CGIHTTPServer.py         |  9 ++++++++-
  Lib/test/test_httpservers.py |  1 +
  Misc/NEWS                    |  2 ++
  3 files changed, 11 insertions(+), 1 deletions(-)


diff --git a/Lib/CGIHTTPServer.py b/Lib/CGIHTTPServer.py
--- a/Lib/CGIHTTPServer.py
+++ b/Lib/CGIHTTPServer.py
@@ -323,7 +323,14 @@
     # Filter out blank non trailing parts before consuming the '..'.
     path_parts = [part for part in path_parts[:-1] if part] + path_parts[-1:]
     if path_parts:
-        tail_part = path_parts.pop()
+        # Special case for CGI's for PATH_INFO
+        if path.startswith('/cgi-bin') or path.startswith('/htbin'):
+            tail_part = []
+            while path_parts[-1] not in ('cgi-bin','htbin'):
+                tail_part.insert(0,path_parts.pop())
+            tail_part = "/".join(tail_part)
+        else:
+            tail_part = path_parts.pop()
     else:
         tail_part = ''
     head_parts = []
diff --git a/Lib/test/test_httpservers.py b/Lib/test/test_httpservers.py
--- a/Lib/test/test_httpservers.py
+++ b/Lib/test/test_httpservers.py
@@ -429,6 +429,7 @@
             '/.//': ('/', ''),
             'cgi-bin/file1.py': ('/cgi-bin', 'file1.py'),
             '/cgi-bin/file1.py': ('/cgi-bin', 'file1.py'),
+            '/cgi-bin/file1.py/PATH-INFO': ('/cgi-bin', 'file1.py/PATH-INFO'),
             'a': ('/', 'a'),
             '/a': ('/', 'a'),
             '//a': ('/', 'a'),
diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -20,6 +20,8 @@
 Library
 -------
 
+- Issue #10484: Fix the CGIHTTPServer's PATH_INFO handling problem.
+
 - Issue #11199: Fix the with urllib which hangs on particular ftp urls.
 
 - Issue #5219: Prevent event handler cascade in IDLE.

-- 
Repository URL: http://hg.python.org/cpython


More information about the Python-checkins mailing list