[Python-checkins] cpython (3.2): Issue12541 - Add UserWarning for unquoted realms
senthil.kumaran
python-checkins at python.org
Tue May 15 18:08:25 CEST 2012
http://hg.python.org/cpython/rev/b5b38bda9fc4
changeset: 76959:b5b38bda9fc4
branch: 3.2
parent: 76953:bb94fec5c5ab
user: Senthil Kumaran <senthil at uthcode.com>
date: Tue May 15 23:59:42 2012 +0800
summary:
Issue12541 - Add UserWarning for unquoted realms
files:
Lib/test/test_urllib2.py | 11 ++++++-----
Lib/urllib/request.py | 4 ++++
2 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/Lib/test/test_urllib2.py b/Lib/test/test_urllib2.py
--- a/Lib/test/test_urllib2.py
+++ b/Lib/test/test_urllib2.py
@@ -1227,11 +1227,12 @@
401, 'WWW-Authenticate: Basic realm=%s\r\n\r\n' % realm)
opener.add_handler(auth_handler)
opener.add_handler(http_handler)
- self._test_basic_auth(opener, auth_handler, "Authorization",
- realm, http_handler, password_manager,
- "http://acme.example.com/protected",
- "http://acme.example.com/protected",
- )
+ with self.assertWarns(UserWarning):
+ self._test_basic_auth(opener, auth_handler, "Authorization",
+ realm, http_handler, password_manager,
+ "http://acme.example.com/protected",
+ "http://acme.example.com/protected",
+ )
def test_proxy_basic_auth(self):
opener = OpenerDirector()
diff --git a/Lib/urllib/request.py b/Lib/urllib/request.py
--- a/Lib/urllib/request.py
+++ b/Lib/urllib/request.py
@@ -95,6 +95,7 @@
import sys
import time
import collections
+import warnings
from urllib.error import URLError, HTTPError, ContentTooShortError
from urllib.parse import (
@@ -827,6 +828,9 @@
mo = AbstractBasicAuthHandler.rx.search(authreq)
if mo:
scheme, quote, realm = mo.groups()
+ if quote not in ["'", '"']:
+ warnings.warn("Basic Auth Realm was unquoted",
+ UserWarning, 2)
if scheme.lower() == 'basic':
response = self.retry_http_basic_auth(host, req, realm)
if response and response.code != 401:
--
Repository URL: http://hg.python.org/cpython
More information about the Python-checkins
mailing list