[Python-checkins] cpython (merge 3.2 -> default): Issue12541 - Add UserWarning for unquoted realms

[senthil.kumaran]

http://hg.python.org/cpython/rev/08fa1a47fa97
changeset:   76960:08fa1a47fa97
parent:      76955:cdea40514623
parent:      76959:b5b38bda9fc4
user:        Senthil Kumaran <senthil at uthcode.com>
date:        Wed May 16 00:03:29 2012 +0800
summary:
  Issue12541 - Add UserWarning for unquoted realms

files:
  Lib/test/test_urllib2.py |  11 ++++++-----
  Lib/urllib/request.py    |   3 +++
  2 files changed, 9 insertions(+), 5 deletions(-)


diff --git a/Lib/test/test_urllib2.py b/Lib/test/test_urllib2.py
--- a/Lib/test/test_urllib2.py
+++ b/Lib/test/test_urllib2.py
@@ -1261,11 +1261,12 @@
             401, 'WWW-Authenticate: Basic realm=%s\r\n\r\n' % realm)
         opener.add_handler(auth_handler)
         opener.add_handler(http_handler)
-        self._test_basic_auth(opener, auth_handler, "Authorization",
-                              realm, http_handler, password_manager,
-                              "http://acme.example.com/protected",
-                              "http://acme.example.com/protected",
-                              )
+        with self.assertWarns(UserWarning):
+            self._test_basic_auth(opener, auth_handler, "Authorization",
+                                realm, http_handler, password_manager,
+                                "http://acme.example.com/protected",
+                                "http://acme.example.com/protected",
+                                )
 
     def test_proxy_basic_auth(self):
         opener = OpenerDirector()
diff --git a/Lib/urllib/request.py b/Lib/urllib/request.py
--- a/Lib/urllib/request.py
+++ b/Lib/urllib/request.py
@@ -934,6 +934,9 @@
                 mo = AbstractBasicAuthHandler.rx.search(authreq)
                 if mo:
                     scheme, quote, realm = mo.groups()
+                    if quote not in ['"',"'"]:
+                        warnings.warn("Basic Auth Realm was unquoted",
+                                      UserWarning, 2)
                     if scheme.lower() == 'basic':
                         response = self.retry_http_basic_auth(host, req, realm)
                         if response and response.code != 401:

-- 
Repository URL: http://hg.python.org/cpython