[Python-checkins] cpython: Remove_uninitialized_compiler_warning

[Amaury Forgeot d'Arc]

Hi,

The previous code looked wrong, but the new "break" will change behaviour.
>From a comment above, the LZMA1 filter needs a "dict_size" as well.
The "fallthrough" was probably intentional.

> diff --git a/Modules/_lzmamodule.c b/Modules/_lzmamodule.c
> --- a/Modules/_lzmamodule.c
> +++ b/Modules/_lzmamodule.c
> @@ -412,7 +412,11 @@
>              ADD_FIELD(options, lc);
>              ADD_FIELD(options, lp);
>              ADD_FIELD(options, pb);
> -        case LZMA_FILTER_LZMA2:
> +            ADD_FIELD(options, dict_size);
> +            break;
> +        }
> +        case LZMA_FILTER_LZMA2: {
> +            lzma_options_lzma *options = f->options;
>              ADD_FIELD(options, dict_size);
>              break;
>          }


-- 
Amaury Forgeot d'Arc
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/python-checkins/attachments/20120512/bee80168/attachment-0001.html>