[Python-checkins] cpython (2.7): #16112: platform.architecture does not correctly escape argument to
jesus.cea
python-checkins at python.org
Fri Oct 5 04:50:40 CEST 2012
http://hg.python.org/cpython/rev/b94a9ff13199
changeset: 79485:b94a9ff13199
branch: 2.7
parent: 79467:06772ba3d001
user: Jesus Cea <jcea at jcea.es>
date: Fri Oct 05 04:50:17 2012 +0200
summary:
#16112: platform.architecture does not correctly escape argument to /usr/bin/file. Use 'communicate()'
files:
Lib/platform.py | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/Lib/platform.py b/Lib/platform.py
--- a/Lib/platform.py
+++ b/Lib/platform.py
@@ -1045,13 +1045,12 @@
return default
target = _follow_symlinks(target)
try:
- with open(DEV_NULL) as dev_null:
- proc = subprocess.Popen(['file', '-b', '--', target],
- stdout=subprocess.PIPE, stderr=dev_null)
+ proc = subprocess.Popen(['file', '-b', '--', target],
+ stdout=subprocess.PIPE, stderr=subprocess.DEVNULL)
except (AttributeError,os.error):
return default
- output = proc.stdout.read()
+ output = proc.communicate()[0]
rc = proc.wait()
if not output or rc:
return default
--
Repository URL: http://hg.python.org/cpython
More information about the Python-checkins
mailing list