[Python-checkins] cpython (3.3): compare with equality not identity (issue #16172)

benjamin.peterson python-checkins at python.org
Tue Oct 9 17:16:42 CEST 2012


http://hg.python.org/cpython/rev/842276ae4a3f
changeset:   79625:842276ae4a3f
branch:      3.3
parent:      79257:83496b5e1916
user:        Benjamin Peterson <benjamin at python.org>
date:        Tue Oct 09 11:14:59 2012 -0400
summary:
  compare with equality not identity (issue #16172)

Patch from Serhiy Storchaka.

files:
  Lib/test/test_winsound.py |  8 ++------
  1 files changed, 2 insertions(+), 6 deletions(-)


diff --git a/Lib/test/test_winsound.py b/Lib/test/test_winsound.py
--- a/Lib/test/test_winsound.py
+++ b/Lib/test/test_winsound.py
@@ -16,16 +16,12 @@
     try:
         # Ask the mixer API for the number of devices it knows about.
         # When there are no devices, PlaySound will fail.
-        if ctypes.windll.winmm.mixerGetNumDevs() is 0:
+        if ctypes.windll.winmm.mixerGetNumDevs() == 0:
             return False
 
         key = winreg.OpenKeyEx(winreg.HKEY_CURRENT_USER,
                 "AppEvents\Schemes\Apps\.Default\{0}\.Default".format(sound))
-        value = winreg.EnumValue(key, 0)[1]
-        if value is not "":
-            return True
-        else:
-            return False
+        return winreg.EnumValue(key, 0)[1] != ""
     except WindowsError:
         return False
 

-- 
Repository URL: http://hg.python.org/cpython


More information about the Python-checkins mailing list