[Python-checkins] cpython (2.7): #17614: IDLE no longer raises exception when quickly closing a file.

[roger.serwy]

http://hg.python.org/cpython/rev/1e5e497ee33b
changeset:   83069:1e5e497ee33b
branch:      2.7
parent:      83061:5d99042bd40f
user:        Roger Serwy <roger.serwy at gmail.com>
date:        Tue Apr 02 22:37:12 2013 -0500
summary:
  #17614: IDLE no longer raises exception when quickly closing a file.

files:
  Lib/idlelib/PyShell.py |  6 +++++-
  Misc/NEWS              |  2 ++
  2 files changed, 7 insertions(+), 1 deletions(-)


diff --git a/Lib/idlelib/PyShell.py b/Lib/idlelib/PyShell.py
--- a/Lib/idlelib/PyShell.py
+++ b/Lib/idlelib/PyShell.py
@@ -116,12 +116,13 @@
         self.breakpointPath = os.path.join(idleConf.GetUserCfgDir(),
                                            'breakpoints.lst')
         # whenever a file is changed, restore breakpoints
-        if self.io.filename: self.restore_file_breaks()
         def filename_changed_hook(old_hook=self.io.filename_change_hook,
                                   self=self):
             self.restore_file_breaks()
             old_hook()
         self.io.set_filename_change_hook(filename_changed_hook)
+        if self.io.filename:
+            self.restore_file_breaks()
 
     rmenu_specs = [
         ("Cut", "<<cut>>", "rmenu_check_cut"),
@@ -237,6 +238,9 @@
 
     def restore_file_breaks(self):
         self.text.update()   # this enables setting "BREAK" tags to be visible
+        if self.io is None:
+            # can happen if IDLE closes due to the .update() call
+            return
         filename = self.io.filename
         if filename is None:
             return
diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -12,6 +12,8 @@
 Library
 -------
 
+- Issue #17614: IDLE no longer raises exception when quickly closing a file.
+
 - Issue #13163: Rename operands in smtplib.SMTP._get_socket to correct names;
   fixes otherwise misleading output in tracebacks and when when debug is on.
 

-- 
Repository URL: http://hg.python.org/cpython