[Python-checkins] cpython (3.3): Add missing check of PyDict_Update()'s return value in _elementtree.c

christian.heimes python-checkins at python.org
Sat Jul 20 15:13:12 CEST 2013


http://hg.python.org/cpython/rev/76bb3fe6ce8f
changeset:   84734:76bb3fe6ce8f
branch:      3.3
parent:      84732:656954ec54a1
user:        Christian Heimes <christian at cheimes.de>
date:        Sat Jul 20 15:12:09 2013 +0200
summary:
  Add missing check of PyDict_Update()'s return value in _elementtree.c
CID 719637

files:
  Modules/_elementtree.c |  3 ++-
  1 files changed, 2 insertions(+), 1 deletions(-)


diff --git a/Modules/_elementtree.c b/Modules/_elementtree.c
--- a/Modules/_elementtree.c
+++ b/Modules/_elementtree.c
@@ -347,7 +347,8 @@
     Py_DECREF(attrib_str);
 
     if (attrib)
-        PyDict_Update(attrib, kwds);
+        if (PyDict_Update(attrib, kwds) < 0)
+            return NULL;
     return attrib;
 }
 

-- 
Repository URL: http://hg.python.org/cpython


More information about the Python-checkins mailing list