[Python-checkins] [Python-Dev] cpython (3.3): return NULL here

Gregory P. Smith greg at krypto.org
Wed Jul 24 08:43:59 CEST 2013


On Tue, Jul 23, 2013 at 8:46 AM, Ronald Oussoren <ronaldoussoren at mac.com>wrote:

>
> On 23 Jul, 2013, at 17:36, Christian Heimes <christian at python.org> wrote:
>
> > Am 23.07.2013 17:10, schrieb Benjamin Peterson:
> >>> PyErr_SetFromErrno() already and always returns NULL. Or do you prefer
> >>> to return NULL explicitly?
> >>
> >> It might always return NULL, but the compiler sees (PyObject *)NULL
> >> when this function returns dl_funcptr.
> >
> > Oh, you are right. I must have missed the compiler warning. How about we
> > turn type return and type assignment warnings into fatal errors?
>
> That's probably possible with a '-Werror=....' argument. But please
> consider
> issue 18211 before unconditionally adding such a flag, as that issue
> mentions
> new compiler flags also get used when compiling 3th-party extensions.
>
> I guess there needs to be (yet) another CFLAGS_xxx variable in the
> Makefile that
> gets added to $(CFLAGS) during the build of Python itself, but is ignored
> by
> distutils and sysconfig.
>

It seems fair to turn those on in 3.4 and require that third party
extensions clean up their code when porting from 3.3 to 3.4.


> Ronald
>
> >
> > Christian
> >
> > _______________________________________________
> > Python-Dev mailing list
> > Python-Dev at python.org
> > http://mail.python.org/mailman/listinfo/python-dev
> > Unsubscribe:
> http://mail.python.org/mailman/options/python-dev/ronaldoussoren%40mac.com
>
> _______________________________________________
> Python-checkins mailing list
> Python-checkins at python.org
> http://mail.python.org/mailman/listinfo/python-checkins
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/python-checkins/attachments/20130723/5168cb3d/attachment.html>


More information about the Python-checkins mailing list