[Python-checkins] cpython (2.7): Issue #18071: Extension module builds on OS X could fail with TypeError

[ned.deily]

http://hg.python.org/cpython/rev/addd9210816b
changeset:   84928:addd9210816b
branch:      2.7
parent:      84902:6e1dd1ce95b8
user:        Ned Deily <nad at acm.org>
date:        Wed Jul 31 00:14:20 2013 -0700
summary:
  Issue #18071: Extension module builds on OS X could fail with TypeError
if Xcode command line tools were not installed.

files:
  Lib/_osx_support.py |  4 ++--
  Misc/NEWS           |  3 +++
  2 files changed, 5 insertions(+), 2 deletions(-)


diff --git a/Lib/_osx_support.py b/Lib/_osx_support.py
--- a/Lib/_osx_support.py
+++ b/Lib/_osx_support.py
@@ -53,7 +53,7 @@
 
 
 def _read_output(commandstring):
-    """Output from succesful command execution or None"""
+    """Output from successful command execution or None"""
     # Similar to os.popen(commandstring, "r").read(),
     # but without actually using os.popen because that
     # function is not usable during python bootstrap.
@@ -68,7 +68,7 @@
 
     with contextlib.closing(fp) as fp:
         cmd = "%s 2>/dev/null >'%s'" % (commandstring, fp.name)
-        return fp.read().decode('utf-8').strip() if not os.system(cmd) else None
+        return fp.read().strip() if not os.system(cmd) else None
 
 
 def _find_build_tool(toolname):
diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -74,6 +74,9 @@
   the default for linking if LDSHARED is not also overriden.  This restores
   Distutils behavior introduced in 2.7.3 and inadvertently dropped in 2.7.4.
 
+- Issue #18071: C extension module builds on OS X could fail with TypeError
+  if the Xcode command line tools were not installed.
+
 - Issue #18113: Fixed a refcount leak in the curses.panel module's
   set_userptr() method.  Reported by Atsuo Ishimoto.
 

-- 
Repository URL: http://hg.python.org/cpython