[Python-checkins] cpython: ../bug-fixes/http_error_interface/.hg/last-message.txt
senthil.kumaran
python-checkins at python.org
Tue Mar 19 20:04:33 CET 2013
http://hg.python.org/cpython/rev/4f2080e9eee2
changeset: 82765:4f2080e9eee2
parent: 82763:4c6463b96a2c
user: Senthil Kumaran <senthil at uthcode.com>
date: Tue Mar 19 12:07:43 2013 -0700
summary:
../bug-fixes/http_error_interface/.hg/last-message.txt
files:
Lib/test/test_urllib2.py | 39 +++++++++++++--------------
1 files changed, 19 insertions(+), 20 deletions(-)
diff --git a/Lib/test/test_urllib2.py b/Lib/test/test_urllib2.py
--- a/Lib/test/test_urllib2.py
+++ b/Lib/test/test_urllib2.py
@@ -1387,6 +1387,10 @@
class MiscTests(unittest.TestCase):
+ def opener_has_handler(self, opener, handler_class):
+ self.assertTrue(any(h.__class__ == handler_class
+ for h in opener.handlers))
+
def test_build_opener(self):
class MyHTTPHandler(urllib.request.HTTPHandler): pass
class FooHandler(urllib.request.BaseHandler):
@@ -1439,10 +1443,22 @@
self.assertEqual(b"1234567890", request.data)
self.assertEqual("10", request.get_header("Content-length"))
+ def test_HTTPError_interface(self):
+ """
+ Issue 13211 reveals that HTTPError didn't implement the URLError
+ interface even though HTTPError is a subclass of URLError.
- def opener_has_handler(self, opener, handler_class):
- self.assertTrue(any(h.__class__ == handler_class
- for h in opener.handlers))
+ >>> msg = 'something bad happened'
+ >>> url = code = fp = None
+ >>> hdrs = 'Content-Length: 42'
+ >>> err = urllib.error.HTTPError(url, code, msg, hdrs, fp)
+ >>> assert hasattr(err, 'reason')
+ >>> err.reason
+ 'something bad happened'
+ >>> assert hasattr(err, 'headers')
+ >>> err.headers
+ 'Content-Length: 42'
+ """
class RequestTests(unittest.TestCase):
@@ -1514,23 +1530,6 @@
req = Request(url)
self.assertEqual(req.get_full_url(), url)
-def test_HTTPError_interface():
- """
- Issue 13211 reveals that HTTPError didn't implement the URLError
- interface even though HTTPError is a subclass of URLError.
-
- >>> msg = 'something bad happened'
- >>> url = code = fp = None
- >>> hdrs = 'Content-Length: 42'
- >>> err = urllib.error.HTTPError(url, code, msg, hdrs, fp)
- >>> assert hasattr(err, 'reason')
- >>> err.reason
- 'something bad happened'
- >>> assert hasattr(err, 'headers')
- >>> err.headers
- 'Content-Length: 42'
- """
-
def test_main(verbose=None):
from test import test_urllib2
support.run_doctest(test_urllib2, verbose)
--
Repository URL: http://hg.python.org/cpython
More information about the Python-checkins
mailing list