[Python-checkins] cpython: Issue #19595: Re-enable a long-disabled test in test_winsound

[zach.ware]

http://hg.python.org/cpython/rev/6f1c5d0b44ed
changeset:   87621:6f1c5d0b44ed
user:        Zachary Ware <zachary.ware at gmail.com>
date:        Wed Nov 27 23:56:04 2013 -0600
summary:
  Issue #19595: Re-enable a long-disabled test in test_winsound

files:
  Lib/test/test_winsound.py |  20 ++++++++------------
  Misc/NEWS                 |   2 ++
  2 files changed, 10 insertions(+), 12 deletions(-)


diff --git a/Lib/test/test_winsound.py b/Lib/test/test_winsound.py
--- a/Lib/test/test_winsound.py
+++ b/Lib/test/test_winsound.py
@@ -158,18 +158,14 @@
             )
 
     def test_alias_fallback(self):
-        # This test can't be expected to work on all systems.  The MS
-        # PlaySound() docs say:
-        #
-        #     If it cannot find the specified sound, PlaySound uses the
-        #     default system event sound entry instead.  If the function
-        #     can find neither the system default entry nor the default
-        #     sound, it makes no sound and returns FALSE.
-        #
-        # It's known to return FALSE on some real systems.
-
-        # winsound.PlaySound('!"$%&/(#+*', winsound.SND_ALIAS)
-        return
+        if _have_soundcard():
+            winsound.PlaySound('!"$%&/(#+*', winsound.SND_ALIAS)
+        else:
+            self.assertRaises(
+                RuntimeError,
+                winsound.PlaySound,
+                '!"$%&/(#+*', winsound.SND_ALIAS
+            )
 
     def test_alias_nofallback(self):
         if _have_soundcard():
diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -31,6 +31,8 @@
 Tests
 -----
 
+- Issue #19595: Re-enabled a long-disabled test in test_winsound.
+
 - Issue #19588: Fixed tests in test_random that were silently skipped most
   of the time.  Patch by Julian Gindi.
 

-- 
Repository URL: http://hg.python.org/cpython