[Python-checkins] cpython: Issue #19169: Micro refactoring with a micro benefit for brevity and speed.

raymond.hettinger python-checkins at python.org
Sun Oct 6 02:20:29 CEST 2013


http://hg.python.org/cpython/rev/1f51867fe50e
changeset:   85985:1f51867fe50e
user:        Raymond Hettinger <python at rcn.com>
date:        Sat Oct 05 17:18:36 2013 -0700
summary:
  Issue #19169:  Micro refactoring with a micro benefit for brevity and speed.

files:
  Lib/random.py |  4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)


diff --git a/Lib/random.py b/Lib/random.py
--- a/Lib/random.py
+++ b/Lib/random.py
@@ -220,10 +220,11 @@
                    Method=_MethodType, BuiltinMethod=_BuiltinMethodType):
         "Return a random int in the range [0,n).  Raises ValueError if n==0."
 
+        random = self.random
         getrandbits = self.getrandbits
         # Only call self.getrandbits if the original random() builtin method
         # has not been overridden or if a new getrandbits() was supplied.
-        if type(self.random) is BuiltinMethod or type(getrandbits) is Method:
+        if type(random) is BuiltinMethod or type(getrandbits) is Method:
             k = n.bit_length()  # don't use (n-1) here because n can be 1
             r = getrandbits(k)          # 0 <= r < 2**k
             while r >= n:
@@ -231,7 +232,6 @@
             return r
         # There's an overriden random() method but no new getrandbits() method,
         # so we can only use random() from here.
-        random = self.random
         if n >= maxsize:
             _warn("Underlying random() generator does not supply \n"
                 "enough bits to choose from a population range this large.\n"

-- 
Repository URL: http://hg.python.org/cpython


More information about the Python-checkins mailing list