[Python-checkins] cpython (3.3): Issue #19327: Fixed the working of regular expressions with too big charset.

[serhiy.storchaka]

http://hg.python.org/cpython/rev/4431fa917f22
changeset:   86600:4431fa917f22
branch:      3.3
parent:      86596:06b9a9e75a6c
user:        Serhiy Storchaka <storchaka at gmail.com>
date:        Thu Oct 24 22:02:58 2013 +0300
summary:
  Issue #19327: Fixed the working of regular expressions with too big charset.

files:
  Lib/sre_compile.py  |  2 +-
  Lib/test/test_re.py |  3 +++
  Misc/NEWS           |  2 ++
  Modules/_sre.c      |  4 ++--
  4 files changed, 8 insertions(+), 3 deletions(-)


diff --git a/Lib/sre_compile.py b/Lib/sre_compile.py
--- a/Lib/sre_compile.py
+++ b/Lib/sre_compile.py
@@ -345,7 +345,7 @@
     else:
         code = 'I'
     # Convert block indices to byte array of 256 bytes
-    mapping = array.array('b', mapping).tobytes()
+    mapping = array.array('B', mapping).tobytes()
     # Convert byte array to word array
     mapping = array.array(code, mapping)
     assert mapping.itemsize == _sre.CODESIZE
diff --git a/Lib/test/test_re.py b/Lib/test/test_re.py
--- a/Lib/test/test_re.py
+++ b/Lib/test/test_re.py
@@ -428,6 +428,9 @@
                                   "\u2222").group(1), "\u2222")
         self.assertEqual(re.match("([\u2222\u2223])",
                                   "\u2222", re.UNICODE).group(1), "\u2222")
+        r = '[%s]' % ''.join(map(chr, range(256, 2**16, 255)))
+        self.assertEqual(re.match(r,
+                                  "\uff01", re.UNICODE).group(), "\uff01")
 
     def test_big_codesize(self):
         # Issue #1160
diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -81,6 +81,8 @@
 Library
 -------
 
+- Issue #19327: Fixed the working of regular expressions with too big charset.
+
 - Issue #19350: Increasing the test coverage of macurl2path. Patch by Colin
   Williams.
 
diff --git a/Modules/_sre.c b/Modules/_sre.c
--- a/Modules/_sre.c
+++ b/Modules/_sre.c
@@ -451,7 +451,7 @@
             count = *(set++);
 
             if (sizeof(SRE_CODE) == 2) {
-                block = ((char*)set)[ch >> 8];
+                block = ((unsigned char*)set)[ch >> 8];
                 set += 128;
                 if (set[block*16 + ((ch & 255)>>4)] & (1 << (ch & 15)))
                     return ok;
@@ -461,7 +461,7 @@
                 /* !(c & ~N) == (c < N+1) for any unsigned c, this avoids
                  * warnings when c's type supports only numbers < N+1 */
                 if (!(ch & ~65535))
-                    block = ((char*)set)[ch >> 8];
+                    block = ((unsigned char*)set)[ch >> 8];
                 else
                     block = -1;
                 set += 64;

-- 
Repository URL: http://hg.python.org/cpython