[Python-checkins] cpython (3.4): simplify check, since now there are only new-style classes

Antoine Pitrou solipsis at pitrou.net
Tue Apr 1 20:36:24 CEST 2014


On Tue, 1 Apr 2014 13:28:53 -0500
Zachary Ware <zachary.ware+pydev at gmail.com> wrote:
> > @@ -524,7 +521,7 @@
> >      skip = set()
> >      for klass in default_classes:
> >          for check in handlers:
> > -            if isclass(check):
> > +            if instance(check, type):
> 
> Should be isinstance, should it not?

Sounds like a well-tested code path :-)

Regards

Antoine.




More information about the Python-checkins mailing list