[Python-checkins] cpython (3.2): in scan_once, prevent the reading of arbitrary memory when passed a negative
benjamin.peterson
python-checkins at python.org
Mon Apr 14 04:32:23 CEST 2014
http://hg.python.org/cpython/rev/8130b8c06606
changeset: 90236:8130b8c06606
branch: 3.2
parent: 90129:b9913eb96643
user: Benjamin Peterson <benjamin at python.org>
date: Sun Apr 13 22:10:38 2014 -0400
summary:
in scan_once, prevent the reading of arbitrary memory when passed a negative index
Bug reported by Guido Vranken.
files:
Lib/test/json_tests/test_decode.py | 4 ++++
Misc/ACKS | 1 +
Misc/NEWS | 3 +++
Modules/_json.c | 5 ++++-
4 files changed, 12 insertions(+), 1 deletions(-)
diff --git a/Lib/test/json_tests/test_decode.py b/Lib/test/json_tests/test_decode.py
--- a/Lib/test/json_tests/test_decode.py
+++ b/Lib/test/json_tests/test_decode.py
@@ -70,5 +70,9 @@
msg = 'escape'
self.assertRaisesRegex(ValueError, msg, self.loads, s)
+ def test_negative_index(self):
+ d = self.json.JSONDecoder()
+ self.assertRaises(ValueError, d.raw_decode, 'a'*42, -50000)
+
class TestPyDecode(TestDecode, PyTest): pass
class TestCDecode(TestDecode, CTest): pass
diff --git a/Misc/ACKS b/Misc/ACKS
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -1139,6 +1139,7 @@
Johannes Vogel
Martijn Vries
Sjoerd de Vries
+Guido Vranken
Niki W. Waibel
Wojtek Walczak
Charles Waldman
diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -10,6 +10,9 @@
Library
-------
+- Fix arbitrary memory access in JSONDecoder.raw_decode with a negative second
+ parameter. Bug reported by Guido Vranken.
+
- Issue #21082: In os.makedirs, do not set the process-wide umask. Note this
changes behavior of makedirs when exist_ok=True.
diff --git a/Modules/_json.c b/Modules/_json.c
--- a/Modules/_json.c
+++ b/Modules/_json.c
@@ -930,7 +930,10 @@
PyObject *res;
Py_UNICODE *str = PyUnicode_AS_UNICODE(pystr);
Py_ssize_t length = PyUnicode_GET_SIZE(pystr);
- if (idx >= length) {
+ if (idx < 0)
+ /* Compatibility with Python version. */
+ idx += length;
+ if (idx < 0 || idx >= length) {
PyErr_SetNone(PyExc_StopIteration);
return NULL;
}
--
Repository URL: http://hg.python.org/cpython
More information about the Python-checkins
mailing list