[Python-checkins] cpython (3.4): Closes Issue 21222.

kushal.das python-checkins at python.org
Tue Apr 15 21:53:10 CEST 2014


http://hg.python.org/cpython/rev/d471b0d38516
changeset:   90330:d471b0d38516
branch:      3.4
parent:      90328:ebb9595af548
user:        Kushal Das <kushaldas at gmail.com>
date:        Wed Apr 16 01:05:50 2014 +0530
summary:
  Closes Issue 21222.

Passing name keyword argument to mock.create_autospec now works.

files:
  Lib/unittest/mock.py                   |  2 ++
  Lib/unittest/test/testmock/testmock.py |  4 ++++
  Misc/NEWS                              |  3 +++
  3 files changed, 9 insertions(+), 0 deletions(-)


diff --git a/Lib/unittest/mock.py b/Lib/unittest/mock.py
--- a/Lib/unittest/mock.py
+++ b/Lib/unittest/mock.py
@@ -2096,6 +2096,8 @@
     elif is_type and instance and not _instance_callable(spec):
         Klass = NonCallableMagicMock
 
+    _name = _kwargs.pop('name', _name)
+
     _new_name = _name
     if _parent is None:
         # for a top level object no _new_name should be set
diff --git a/Lib/unittest/test/testmock/testmock.py b/Lib/unittest/test/testmock/testmock.py
--- a/Lib/unittest/test/testmock/testmock.py
+++ b/Lib/unittest/test/testmock/testmock.py
@@ -1182,6 +1182,10 @@
                 func.mock_calls, [call(1, 2), call(3, 4)]
             )
 
+    #Issue21222
+    def test_create_autospec_with_name(self):
+        m = mock.create_autospec(object(), name='sweet_func')
+        self.assertIn('sweet_func', repr(m))
 
     def test_mock_add_spec(self):
         class _One(object):
diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -37,6 +37,9 @@
 Library
 -------
 
+- Issue #21222: Passing name keyword argument to mock.create_autospec now
+  works.
+
 - Issue #21197: Add lib64 -> lib symlink in venvs on 64-bit non-OS X POSIX.
 
 - Issue #17498: Some SMTP servers disconnect after certain errors, violating

-- 
Repository URL: http://hg.python.org/cpython


More information about the Python-checkins mailing list