[Python-checkins] cpython: #20013: don't raise socket error when selected mailbox deleted.

r.david.murray python-checkins at python.org
Fri Feb 7 19:45:45 CET 2014


http://hg.python.org/cpython/rev/a24f7d195b8f
changeset:   89021:a24f7d195b8f
user:        R David Murray <rdmurray at bitdance.com>
date:        Fri Feb 07 13:44:57 2014 -0500
summary:
  #20013: don't raise socket error when selected mailbox deleted.

I'm checking this in without a test because not much of this code
is tested and I don't have time to work up the necessary extensions
to the existing test framework.

The patch itself was tested by the person who reported the bug.

files:
  Lib/imaplib.py |  5 +++++
  Misc/NEWS      |  4 ++++
  2 files changed, 9 insertions(+), 0 deletions(-)


diff --git a/Lib/imaplib.py b/Lib/imaplib.py
--- a/Lib/imaplib.py
+++ b/Lib/imaplib.py
@@ -1063,6 +1063,11 @@
                 del self.tagged_commands[tag]
                 return result
 
+            # If we've seen a BYE at this point, the socket will be
+            # closed, so report the BYE now.
+
+            self._check_bye()
+
             # Some have reported "unexpected response" exceptions.
             # Note that ignoring them here causes loops.
             # Instead, send me details of the unexpected response and
diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -24,6 +24,10 @@
 Library
 -------
 
+- Issue #20013: Some imap servers disconnect if the current mailbox is
+  deleted, and imaplib did not handle that case gracefully.  Now it
+  handles the 'bye' correctly.
+
 - Issue #20531: Revert 3.4 version of fix for #19063, and apply the 3.3
   version.  That is, do *not* raise an error if unicode is passed to
   email.message.Message.set_payload.

-- 
Repository URL: http://hg.python.org/cpython


More information about the Python-checkins mailing list