[Python-checkins] cpython (3.3): #19855: restore use of LC_ALL, not LC_MESSAGES

r.david.murray python-checkins at python.org
Sat Jan 18 21:02:59 CET 2014


http://hg.python.org/cpython/rev/706354c4d8f5
changeset:   88557:706354c4d8f5
branch:      3.3
parent:      88554:52edc7087c81
user:        R David Murray <rdmurray at bitdance.com>
date:        Sat Jan 18 14:56:10 2014 -0500
summary:
  #19855: restore use of LC_ALL, not LC_MESSAGES

I didn't realize LC_ALL was an override, and I should have.  I tried to
make a test, but it is not clear that the LC variables actually affect
the strings that uuid is using to parse the command output.

files:
  Lib/uuid.py |  4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)


diff --git a/Lib/uuid.py b/Lib/uuid.py
--- a/Lib/uuid.py
+++ b/Lib/uuid.py
@@ -321,9 +321,9 @@
             return None
 
     try:
-        # LC_MESSAGES to get English output, 2>/dev/null to
+        # LC_ALL to ensure English output, 2>/dev/null to
         # prevent output on stderr
-        cmd = 'LC_MESSAGES=C %s %s 2>/dev/null' % (executable, args)
+        cmd = 'LC_ALL=C %s %s 2>/dev/null' % (executable, args)
         with os.popen(cmd) as pipe:
             for line in pipe:
                 words = line.lower().split()

-- 
Repository URL: http://hg.python.org/cpython


More information about the Python-checkins mailing list