[Python-checkins] cpython (merge 3.3 -> default): Issue #16655: Explain why Idle's test_calltips has 'fragile' tests of builtins.

[terry.reedy]

http://hg.python.org/cpython/rev/c4a2d0538441
changeset:   88606:c4a2d0538441
parent:      88602:5b497ccfd4af
parent:      88605:4a505a901b2e
user:        Terry Jan Reedy <tjreedy at udel.edu>
date:        Tue Jan 21 03:10:01 2014 -0500
summary:
  Issue #16655: Explain why Idle's test_calltips has 'fragile' tests of builtins.
Pending Clinic/inspect changes will probably require change to this file.

files:
  Lib/idlelib/idle_test/test_calltips.py |  8 ++++++++
  1 files changed, 8 insertions(+), 0 deletions(-)


diff --git a/Lib/idlelib/idle_test/test_calltips.py b/Lib/idlelib/idle_test/test_calltips.py
--- a/Lib/idlelib/idle_test/test_calltips.py
+++ b/Lib/idlelib/idle_test/test_calltips.py
@@ -33,8 +33,16 @@
 
 signature = ct.get_argspec  # 2.7 and 3.x use different functions
 class Get_signatureTest(unittest.TestCase):
+    # The signature function must return a string, even if blank.
+    # Test a variety of objects to be sure that none cause it to raise
+    # (quite aside from getting as correct an answer as possible).
+    # The tests of builtins may break if inspect or the docstrings change,
+    # but a red buildbot is better than a user crash (as has happened).
+    # For a simple mismatch, change the expected output to the actual.
 
     def test_builtins(self):
+        # These test will break if
+
         # Python class that inherits builtin methods
         class List(list): "List() doc"
         # Simulate builtin with no docstring for default argspec test

-- 
Repository URL: http://hg.python.org/cpython