[Python-checkins] cpython (3.3): Issue #17721: Remove non-functional configuration dialog help button until we

terry.reedy python-checkins at python.org
Mon Jan 27 04:28:03 CET 2014


http://hg.python.org/cpython/rev/6e4b94019eae
changeset:   88754:6e4b94019eae
branch:      3.3
parent:      88751:9ac2016815c9
user:        Terry Jan Reedy <tjreedy at udel.edu>
date:        Sun Jan 26 22:24:26 2014 -0500
summary:
  Issue #17721: Remove non-functional configuration dialog help button until we
make it actually gives some help when clicked. Patch by Guilherme Simões.

files:
  Lib/idlelib/configDialog.py |  9 +++++----
  Misc/NEWS                   |  5 ++++-
  2 files changed, 9 insertions(+), 5 deletions(-)


diff --git a/Lib/idlelib/configDialog.py b/Lib/idlelib/configDialog.py
--- a/Lib/idlelib/configDialog.py
+++ b/Lib/idlelib/configDialog.py
@@ -82,9 +82,10 @@
         else:
             extraKwds=dict(padx=6, pady=3)
 
-        self.buttonHelp = Button(frameActionButtons,text='Help',
-                command=self.Help,takefocus=FALSE,
-                **extraKwds)
+# Comment out button creation and packing until implement self.Help
+##        self.buttonHelp = Button(frameActionButtons,text='Help',
+##                command=self.Help,takefocus=FALSE,
+##                **extraKwds)
         self.buttonOk = Button(frameActionButtons,text='Ok',
                 command=self.Ok,takefocus=FALSE,
                 **extraKwds)
@@ -98,7 +99,7 @@
         self.CreatePageHighlight()
         self.CreatePageKeys()
         self.CreatePageGeneral()
-        self.buttonHelp.pack(side=RIGHT,padx=5)
+##        self.buttonHelp.pack(side=RIGHT,padx=5)
         self.buttonOk.pack(side=LEFT,padx=5)
         self.buttonApply.pack(side=LEFT,padx=5)
         self.buttonCancel.pack(side=LEFT,padx=5)
diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -276,7 +276,10 @@
 IDLE
 ----
 
---Issue #17390: Add Python version to Idle editor window title bar.
+- Issue #17721: Remove non-functional configuration dialog help button until we
+  make it actually gives some help when clicked. Patch by Guilherme Simões.
+
+- Issue #17390: Add Python version to Idle editor window title bar.
   Original patches by Edmond Burnett and Kent Johnson.
 
 - Issue #18960: IDLE now ignores the source encoding declaration on the second

-- 
Repository URL: http://hg.python.org/cpython


More information about the Python-checkins mailing list