[Python-checkins] cpython (2.7): Remove inaccurate comment and a the related recently added

gregory.p.smith python-checkins at python.org
Tue Jan 28 07:43:42 CET 2014


http://hg.python.org/cpython/rev/f9c54ada1b32
changeset:   88790:f9c54ada1b32
branch:      2.7
user:        Gregory P. Smith <greg at krypto.org>
date:        Mon Jan 27 22:43:25 2014 -0800
summary:
  Remove inaccurate comment and a the related recently added
Py_VerboseFlag print that can never be triggered.

prefix[0] is always equal to 0 at this point in the code.

files:
  Modules/zipimport.c |  7 -------
  1 files changed, 0 insertions(+), 7 deletions(-)


diff --git a/Modules/zipimport.c b/Modules/zipimport.c
--- a/Modules/zipimport.c
+++ b/Modules/zipimport.c
@@ -134,13 +134,6 @@
     }
     if (path != NULL) {
         PyObject *files;
-        if (Py_VerboseFlag && prefix && prefix[0] != '\0')
-            PySys_WriteStderr("# zipimport: prefix=%s constructing a "
-                              "zipimporter for %s\n", prefix, path);
-        /* NOTE(gps): test_zipimport.py never exercises a case where
-         * prefix is non-empty.  When would that ever be possible?
-         * Are we missing coverage or is prefix simply never needed?
-         */
         files = PyDict_GetItemString(zip_directory_cache, path);
         if (files == NULL) {
             PyObject *zip_stat = NULL;

-- 
Repository URL: http://hg.python.org/cpython


More information about the Python-checkins mailing list