[Python-checkins] cpython: Minor factoring: move redundant resize scaling logic into the resize function.

[raymond.hettinger]

https://hg.python.org/cpython/rev/596ca185e3dc
changeset:   96790:596ca185e3dc
user:        Raymond Hettinger <python at rcn.com>
date:        Fri Jul 03 20:00:03 2015 -0700
summary:
  Minor factoring:  move redundant resize scaling logic into the resize function.

files:
  Objects/setobject.c |  9 +++++----
  1 files changed, 5 insertions(+), 4 deletions(-)


diff --git a/Objects/setobject.c b/Objects/setobject.c
--- a/Objects/setobject.c
+++ b/Objects/setobject.c
@@ -226,7 +226,7 @@
     entry->hash = hash;
     if ((size_t)so->fill*3 < mask*2)
         return 0;
-    return set_table_resize(so, so->used>50000 ? so->used*2 : so->used*4);
+    return set_table_resize(so, so->used);
 
   found_active:
     return 0;
@@ -290,6 +290,7 @@
     setentry small_copy[PySet_MINSIZE];
 
     assert(minused >= 0);
+    minused = (minused > 50000) ? minused * 2 : minused * 4;
 
     /* Find the smallest table size > minused. */
     /* XXX speed-up with intrinsics */
@@ -616,7 +617,7 @@
      * that there will be no (or few) overlapping keys.
      */
     if ((so->fill + other->used)*3 >= so->mask*2) {
-       if (set_table_resize(so, (so->used + other->used)*2) != 0)
+       if (set_table_resize(so, so->used + other->used) != 0)
            return -1;
     }
     so_entry = so->table;
@@ -965,7 +966,7 @@
         if (dictsize == -1)
             return -1;
         if ((so->fill + dictsize)*3 >= so->mask*2) {
-            if (set_table_resize(so, (so->used + dictsize)*2) != 0)
+            if (set_table_resize(so, so->used + dictsize) != 0)
                 return -1;
         }
         while (_PyDict_Next(other, &pos, &key, &value, &hash)) {
@@ -1508,7 +1509,7 @@
     /* If more than 1/5 are dummies, then resize them away. */
     if ((so->fill - so->used) * 5 < so->mask)
         return 0;
-    return set_table_resize(so, so->used>50000 ? so->used*2 : so->used*4);
+    return set_table_resize(so, so->used);
 }
 
 static PyObject *

-- 
Repository URL: https://hg.python.org/cpython