[Python-checkins] cpython (2.7): Set a default BasePlatformToolset to allow the ICC buildbot to build.

zach.ware python-checkins at python.org
Tue Jul 28 07:01:12 CEST 2015


https://hg.python.org/cpython/rev/d4f64d27ded7
changeset:   97097:d4f64d27ded7
branch:      2.7
parent:      97088:68cd7a64fbb0
user:        Zachary Ware <zachary.ware at gmail.com>
date:        Tue Jul 28 00:00:47 2015 -0500
summary:
  Set a default BasePlatformToolset to allow the ICC buildbot to build.

files:
  PCbuild/pyproject.props |  5 +++--
  PCbuild/python.props    |  5 ++++-
  2 files changed, 7 insertions(+), 3 deletions(-)


diff --git a/PCbuild/pyproject.props b/PCbuild/pyproject.props
--- a/PCbuild/pyproject.props
+++ b/PCbuild/pyproject.props
@@ -11,8 +11,9 @@
     <GenerateManifest Condition="'$(GenerateManifest)' == ''">false</GenerateManifest>
     <EmbedManifest Condition="'$(EmbedManifest)' == ''">false</EmbedManifest>
     <!-- For VS2008, we have to embed the manifest to be able to run -->
-    <GenerateManifest Condition="'$(PlatformToolset)' == 'v90'">true</GenerateManifest>
-    <EmbedManifest Condition="'$(PlatformToolset)' == 'v90'">true</EmbedManifest>
+    <!-- BasePlatformToolset is for ICC support -->
+    <GenerateManifest Condition="'$(PlatformToolset)' == 'v90' or '$(BasePlatformToolset)' == 'v90'">true</GenerateManifest>
+    <EmbedManifest Condition="'$(PlatformToolset)' == 'v90' or '$(BasePlatformToolset)' == 'v90'">true</EmbedManifest>
     <SupportPGO Condition="'$(SupportPGO)' == ''">true</SupportPGO>
     <SupportSigning Condition="'$(SupportSigning)' == ''">true</SupportSigning>
     <SupportSigning Condition="'$(Configuration)' == 'Debug'">false</SupportSigning>
diff --git a/PCbuild/python.props b/PCbuild/python.props
--- a/PCbuild/python.props
+++ b/PCbuild/python.props
@@ -7,7 +7,10 @@
     Use only MSVC 9.0, unless explicitly overridden
     -->
     <PlatformToolset Condition="'$(PlatformToolset)' == ''">v90</PlatformToolset>
-
+    <!--
+    Give a default for BasePlatformToolset as well, it's used by ICC and ignored otherwise
+    -->
+    <BasePlatformToolset Condition="'$(BasePlatformToolset)' == '' and '$(PlatformToolset)' != 'v90'">v90</BasePlatformToolset>
     <!--
     Convincing MSVC/MSBuild to prefer our platform names is too difficult,
     so we define our own constant ArchName and use wherever we need it.

-- 
Repository URL: https://hg.python.org/cpython


More information about the Python-checkins mailing list