[Python-checkins] cpython (2.7): #23647: Increase imaplib's MAXLINE to accommodate modern mailbox sizes.

r.david.murray python-checkins at python.org
Sun Mar 22 21:21:03 CET 2015


https://hg.python.org/cpython/rev/a56aa567072c
changeset:   95132:a56aa567072c
branch:      2.7
parent:      95129:5c3dc817ffd7
user:        R David Murray <rdmurray at bitdance.com>
date:        Sun Mar 22 16:17:11 2015 -0400
summary:
  #23647: Increase imaplib's MAXLINE to accommodate modern mailbox sizes.

files:
  Lib/imaplib.py |  11 ++++++-----
  Misc/NEWS      |   2 ++
  2 files changed, 8 insertions(+), 5 deletions(-)


diff --git a/Lib/imaplib.py b/Lib/imaplib.py
--- a/Lib/imaplib.py
+++ b/Lib/imaplib.py
@@ -37,11 +37,12 @@
 
 # Maximal line length when calling readline(). This is to prevent
 # reading arbitrary length lines. RFC 3501 and 2060 (IMAP 4rev1)
-# don't specify a line length. RFC 2683 however suggests limiting client
-# command lines to 1000 octets and server command lines to 8000 octets.
-# We have selected 10000 for some extra margin and since that is supposedly
-# also what UW and Panda IMAP does.
-_MAXLINE = 10000
+# don't specify a line length. RFC 2683 suggests limiting client
+# command lines to 1000 octets and that servers should be prepared
+# to accept command lines up to 8000 octets, so we used to use 10K here.
+# In the modern world (eg: gmail) the response to, for example, a
+# search command can be quite large, so we now use 1M.
+_MAXLINE = 1000000
 
 
 #       Commands
diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -21,6 +21,8 @@
 Library
 -------
 
+- Issue #23647: Increase impalib's MAXLINE to accommodate modern mailbox sizes.
+
 - Issue #23539: If body is None, http.client.HTTPConnection.request now sets
   Content-Length to 0 for PUT, POST, and PATCH headers to avoid 411 errors from
   some web servers.

-- 
Repository URL: https://hg.python.org/cpython


More information about the Python-checkins mailing list