[Python-checkins] cpython (3.4): Issue #23840: tokenize.open() now closes the temporary binary file on error to

[Yury Selivanov]

On 2015-05-26 12:26 AM, Terry Reedy wrote:
>> +    try:
>> +        encoding, lines = detect_encoding(buffer.readline)
>> +        buffer.seek(0)
>> +        text = TextIOWrapper(buffer, encoding, line_buffering=True)
>> +        text.mode = 'r'
>> +        return text
>> +    except:
>> +        buffer.close()
>> +        raise
>
> Please do not add bare 'except:'.  If you mean 'except 
> BaseException:', say so. 

try..finally would be even better.

Yury