[Python-checkins] cpython: Replace an unpredictable branch with a simple addition.

raymond.hettinger python-checkins at python.org
Thu Sep 24 04:15:50 CEST 2015


https://hg.python.org/cpython/rev/2b71c9db17a5
changeset:   98230:2b71c9db17a5
parent:      98227:e426969e7e1d
user:        Raymond Hettinger <python at rcn.com>
date:        Wed Sep 23 19:15:44 2015 -0700
summary:
  Replace an unpredictable branch with a simple addition.

files:
  Modules/_collectionsmodule.c |  5 ++---
  1 files changed, 2 insertions(+), 3 deletions(-)


diff --git a/Modules/_collectionsmodule.c b/Modules/_collectionsmodule.c
--- a/Modules/_collectionsmodule.c
+++ b/Modules/_collectionsmodule.c
@@ -852,10 +852,9 @@
         CHECK_NOT_END(b);
         item = b->data[index];
         cmp = PyObject_RichCompareBool(item, v, Py_EQ);
-        if (cmp > 0)
-            count++;
-        else if (cmp < 0)
+        if (cmp < 0)
             return NULL;
+        count += cmp;
 
         if (start_state != deque->state) {
             PyErr_SetString(PyExc_RuntimeError,

-- 
Repository URL: https://hg.python.org/cpython


More information about the Python-checkins mailing list