[Python-checkins] cpython: Issue #26782: Add STARTUPINFO to subprocess.__all__ on Windows

[martin.panter]

https://hg.python.org/cpython/rev/3e93ac5a7afa
changeset:   101029:3e93ac5a7afa
user:        Martin Panter <vadmium+py at gmail.com>
date:        Sat Apr 16 23:42:37 2016 +0000
summary:
  Issue #26782: Add STARTUPINFO to subprocess.__all__ on Windows

files:
  Doc/whatsnew/3.6.rst        |  2 +-
  Lib/subprocess.py           |  3 ++-
  Lib/test/test_subprocess.py |  3 +--
  Misc/NEWS                   |  2 ++
  4 files changed, 6 insertions(+), 4 deletions(-)


diff --git a/Doc/whatsnew/3.6.rst b/Doc/whatsnew/3.6.rst
--- a/Doc/whatsnew/3.6.rst
+++ b/Doc/whatsnew/3.6.rst
@@ -500,7 +500,7 @@
   attributes to match the documented APIs: :mod:`calendar`, :mod:`csv`,
   :mod:`~xml.etree.ElementTree`, :mod:`enum`,
   :mod:`fileinput`, :mod:`ftplib`, :mod:`logging`,
-  :mod:`optparse`, :mod:`tarfile`, :mod:`threading` and
+  :mod:`optparse`, :mod:`subprocess`, :mod:`tarfile`, :mod:`threading` and
   :mod:`wave`.  This means they will export new symbols when ``import *``
   is used.  See :issue:`23883`.
 
diff --git a/Lib/subprocess.py b/Lib/subprocess.py
--- a/Lib/subprocess.py
+++ b/Lib/subprocess.py
@@ -471,7 +471,8 @@
     __all__.extend(["CREATE_NEW_CONSOLE", "CREATE_NEW_PROCESS_GROUP",
                     "STD_INPUT_HANDLE", "STD_OUTPUT_HANDLE",
                     "STD_ERROR_HANDLE", "SW_HIDE",
-                    "STARTF_USESTDHANDLES", "STARTF_USESHOWWINDOW"])
+                    "STARTF_USESTDHANDLES", "STARTF_USESHOWWINDOW",
+                    "STARTUPINFO"])
 
     class Handle(int):
         closed = False
diff --git a/Lib/test/test_subprocess.py b/Lib/test/test_subprocess.py
--- a/Lib/test/test_subprocess.py
+++ b/Lib/test/test_subprocess.py
@@ -2540,8 +2540,7 @@
 
     def test__all__(self):
         """Ensure that __all__ is populated properly."""
-        # STARTUPINFO added to __all__ in 3.6
-        intentionally_excluded = {"list2cmdline", "STARTUPINFO", "Handle"}
+        intentionally_excluded = {"list2cmdline", "Handle"}
         exported = set(subprocess.__all__)
         possible_exports = set()
         import types
diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -245,6 +245,8 @@
 Library
 -------
 
+- Issue #26782: Add STARTUPINFO to subprocess.__all__ on Windows.
+
 - Issue #26404: Add context manager to socketserver.  Patch by Aviv Palivoda.
 
 - Issue #26735: Fix :func:`os.urandom` on Solaris 11.3 and newer when reading

-- 
Repository URL: https://hg.python.org/cpython