[Python-checkins] cpython (2.7): Issue #26837: assertSequenceEqual() now correctly outputs non-stringified
serhiy.storchaka
python-checkins at python.org
Mon Apr 25 02:00:13 EDT 2016
https://hg.python.org/cpython/rev/d0d541c2afb7
changeset: 101134:d0d541c2afb7
branch: 2.7
parent: 101101:9b565815079a
user: Serhiy Storchaka <storchaka at gmail.com>
date: Mon Apr 25 08:59:35 2016 +0300
summary:
Issue #26837: assertSequenceEqual() now correctly outputs non-stringified
differing items. This affects assertListEqual() and assertTupleEqual().
files:
Lib/unittest/case.py | 6 +++---
Misc/NEWS | 3 +++
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/Lib/unittest/case.py b/Lib/unittest/case.py
--- a/Lib/unittest/case.py
+++ b/Lib/unittest/case.py
@@ -689,7 +689,7 @@
if item1 != item2:
differing += ('\nFirst differing element %d:\n%s\n%s\n' %
- (i, item1, item2))
+ (i, safe_repr(item1), safe_repr(item2)))
break
else:
if (len1 == len2 and seq_type is None and
@@ -702,7 +702,7 @@
'elements.\n' % (seq_type_name, len1 - len2))
try:
differing += ('First extra element %d:\n%s\n' %
- (len2, seq1[len2]))
+ (len2, safe_repr(seq1[len2])))
except (TypeError, IndexError, NotImplementedError):
differing += ('Unable to index element %d '
'of first %s\n' % (len2, seq_type_name))
@@ -711,7 +711,7 @@
'elements.\n' % (seq_type_name, len2 - len1))
try:
differing += ('First extra element %d:\n%s\n' %
- (len1, seq2[len1]))
+ (len1, safe_repr(seq2[len1])))
except (TypeError, IndexError, NotImplementedError):
differing += ('Unable to index element %d '
'of second %s\n' % (len1, seq_type_name))
diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -77,6 +77,9 @@
Library
-------
+- Issue #26837: assertSequenceEqual() now correctly outputs non-stringified
+ differing items. This affects assertListEqual() and assertTupleEqual().
+
- Issue #26822: itemgetter, attrgetter and methodcaller objects no longer
silently ignore keyword arguments.
--
Repository URL: https://hg.python.org/cpython
More information about the Python-checkins
mailing list