[Python-checkins] cpython: Issue #12946: Remove dead code in PyModule_GetDict

berker.peksag python-checkins at python.org
Fri Aug 19 04:59:36 EDT 2016


https://hg.python.org/cpython/rev/4b64a049f451
changeset:   102752:4b64a049f451
user:        Berker Peksag <berker.peksag at gmail.com>
date:        Fri Aug 19 12:00:13 2016 +0300
summary:
  Issue #12946: Remove dead code in PyModule_GetDict

PyModule_NewObject already sets md_dict to PyDict_New():

    m->md_dict = PyDict_New();

files:
  Objects/moduleobject.c |  3 +--
  1 files changed, 1 insertions(+), 2 deletions(-)


diff --git a/Objects/moduleobject.c b/Objects/moduleobject.c
--- a/Objects/moduleobject.c
+++ b/Objects/moduleobject.c
@@ -444,8 +444,7 @@
         return NULL;
     }
     d = ((PyModuleObject *)m) -> md_dict;
-    if (d == NULL)
-        ((PyModuleObject *)m) -> md_dict = d = PyDict_New();
+    assert(d != NULL);
     return d;
 }
 

-- 
Repository URL: https://hg.python.org/cpython


More information about the Python-checkins mailing list