[Python-checkins] cpython (3.5): #22709: Use stdin as-is if it does not have a buffer attribute.
r.david.murray
python-checkins at python.org
Sat Jan 2 15:45:07 EST 2016
https://hg.python.org/cpython/rev/ded1336bff49
changeset: 99758:ded1336bff49
branch: 3.5
parent: 99756:6b9d8957aeef
user: R David Murray <rdmurray at bitdance.com>
date: Sat Jan 02 15:41:41 2016 -0500
summary:
#22709: Use stdin as-is if it does not have a buffer attribute.
This restores backward compatibility lost in the fix for #21075, and
is better duck typing.
Patch by Akira Li.
files:
Lib/fileinput.py | 2 +-
Lib/test/test_fileinput.py | 11 +++++++++++
Misc/NEWS | 3 +++
3 files changed, 15 insertions(+), 1 deletions(-)
diff --git a/Lib/fileinput.py b/Lib/fileinput.py
--- a/Lib/fileinput.py
+++ b/Lib/fileinput.py
@@ -328,7 +328,7 @@
if self._filename == '-':
self._filename = '<stdin>'
if 'b' in self._mode:
- self._file = sys.stdin.buffer
+ self._file = getattr(sys.stdin, 'buffer', sys.stdin)
else:
self._file = sys.stdin
self._isstdin = True
diff --git a/Lib/test/test_fileinput.py b/Lib/test/test_fileinput.py
--- a/Lib/test/test_fileinput.py
+++ b/Lib/test/test_fileinput.py
@@ -240,6 +240,17 @@
lines = list(fi)
self.assertEqual(lines, [b'spam, bacon, sausage, and spam'])
+ def test_detached_stdin_binary_mode(self):
+ orig_stdin = sys.stdin
+ try:
+ sys.stdin = BytesIO(b'spam, bacon, sausage, and spam')
+ self.assertFalse(hasattr(sys.stdin, 'buffer'))
+ fi = FileInput(files=['-'], mode='rb')
+ lines = list(fi)
+ self.assertEqual(lines, [b'spam, bacon, sausage, and spam'])
+ finally:
+ sys.stdin = orig_stdin
+
def test_file_opening_hook(self):
try:
# cannot use openhook and inplace mode
diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -41,6 +41,9 @@
Library
-------
+- Issue #25447: fileinput now uses sys.stdin as-is if it does not have a
+ buffer attribute (restores backward compatibility).
+
- Issue #25447: Copying the lru_cache() wrapper object now always works,
independedly from the type of the wrapped object (by returning the original
object unchanged).
--
Repository URL: https://hg.python.org/cpython
More information about the Python-checkins
mailing list