[Python-checkins] cpython (3.5): Issue #20254: Fix duplicate tests in test_socket

berker.peksag python-checkins at python.org
Sun Oct 2 04:38:16 EDT 2016


https://hg.python.org/cpython/rev/6406322f4749
changeset:   104239:6406322f4749
branch:      3.5
parent:      104235:ec84d815e90f
user:        Berker Peksag <berker.peksag at gmail.com>
date:        Sun Oct 02 11:39:41 2016 +0300
summary:
  Issue #20254: Fix duplicate tests in test_socket

Patch by Vajrasky Kok.

files:
  Lib/test/test_socket.py |  6 ++++--
  1 files changed, 4 insertions(+), 2 deletions(-)


diff --git a/Lib/test/test_socket.py b/Lib/test/test_socket.py
--- a/Lib/test/test_socket.py
+++ b/Lib/test/test_socket.py
@@ -4629,9 +4629,10 @@
         SocketConnectedTest.__init__(self, methodName=methodName)
 
     def testRecvIntoArray(self):
-        buf = bytearray(1024)
+        buf = array.array("B", [0] * len(MSG))
         nbytes = self.cli_conn.recv_into(buf)
         self.assertEqual(nbytes, len(MSG))
+        buf = buf.tobytes()
         msg = buf[:len(MSG)]
         self.assertEqual(msg, MSG)
 
@@ -4658,9 +4659,10 @@
     _testRecvIntoMemoryview = _testRecvIntoArray
 
     def testRecvFromIntoArray(self):
-        buf = bytearray(1024)
+        buf = array.array("B", [0] * len(MSG))
         nbytes, addr = self.cli_conn.recvfrom_into(buf)
         self.assertEqual(nbytes, len(MSG))
+        buf = buf.tobytes()
         msg = buf[:len(MSG)]
         self.assertEqual(msg, MSG)
 

-- 
Repository URL: https://hg.python.org/cpython


More information about the Python-checkins mailing list