[Python-checkins] cpython (3.5): Issue #28222: Don't fail if pygments is not available

berker.peksag python-checkins at python.org
Tue Oct 4 13:53:28 EDT 2016


https://hg.python.org/cpython/rev/fa09ba71babb
changeset:   104292:fa09ba71babb
branch:      3.5
parent:      104289:8c8692da071a
user:        Berker Peksag <berker.peksag at gmail.com>
date:        Tue Oct 04 20:54:44 2016 +0300
summary:
  Issue #28222: Don't fail if pygments is not available

We can't just skip the test if docutils is available,
but pygments is not because the purpose of the test
was testing a bug in _check_rst_data().

files:
  Lib/distutils/tests/test_check.py |  16 ++++++++++++++--
  1 files changed, 14 insertions(+), 2 deletions(-)


diff --git a/Lib/distutils/tests/test_check.py b/Lib/distutils/tests/test_check.py
--- a/Lib/distutils/tests/test_check.py
+++ b/Lib/distutils/tests/test_check.py
@@ -7,6 +7,12 @@
 from distutils.tests import support
 from distutils.errors import DistutilsSetupError
 
+try:
+    import pygments
+except ImportError:
+    pygments = None
+
+
 class CheckTestCase(support.LoggingSilencer,
                     support.TempdirManager,
                     unittest.TestCase):
@@ -119,9 +125,15 @@
             pkg_info, dist = self.create_dist(long_description=rest_with_code)
             cmd = check(dist)
             cmd.check_restructuredtext()
-            self.assertEqual(cmd._warnings, 0)
             msgs = cmd._check_rst_data(rest_with_code)
-            self.assertEqual(len(msgs), 0)
+            if pygments is not None:
+                self.assertEqual(len(msgs), 0)
+            else:
+                self.assertEqual(len(msgs), 1)
+                self.assertEqual(
+                    str(msgs[0][1]),
+                    'Cannot analyze code. Pygments package not found.'
+                )
 
     def test_check_all(self):
 

-- 
Repository URL: https://hg.python.org/cpython


More information about the Python-checkins mailing list