[Python-checkins] cpython: Issue #29368: Fix _Pickle_FastCall() usage in do_append()

victor.stinner python-checkins at python.org
Thu Feb 2 04:58:37 EST 2017


https://hg.python.org/cpython/rev/328147c0edc3
changeset:   106381:328147c0edc3
user:        Victor Stinner <victor.stinner at gmail.com>
date:        Thu Feb 02 10:56:47 2017 +0100
summary:
  Issue #29368: Fix _Pickle_FastCall() usage in do_append()

_Pickle_FastCall() has a surprising API: it decrements the reference counter of
its second argument.

files:
  Modules/_pickle.c |  1 -
  1 files changed, 0 insertions(+), 1 deletions(-)


diff --git a/Modules/_pickle.c b/Modules/_pickle.c
--- a/Modules/_pickle.c
+++ b/Modules/_pickle.c
@@ -5844,7 +5844,6 @@
                 return -1;
             }
             result = _Pickle_FastCall(extend_func, slice);
-            Py_DECREF(slice);
             Py_DECREF(extend_func);
             if (result == NULL)
                 return -1;

-- 
Repository URL: https://hg.python.org/cpython


More information about the Python-checkins mailing list