[Python-checkins] cpython (3.6): Issue #29513: Fixed a reference leak in os.scandir() added in issue #29034.

serhiy.storchaka python-checkins at python.org
Thu Feb 9 13:07:36 EST 2017


https://hg.python.org/cpython/rev/4e3a16bdadae
changeset:   106477:4e3a16bdadae
branch:      3.6
parent:      106474:80970cf56048
user:        Serhiy Storchaka <storchaka at gmail.com>
date:        Thu Feb 09 20:02:37 2017 +0200
summary:
  Issue #29513: Fixed a reference leak in os.scandir() added in issue #29034.

files:
  Modules/posixmodule.c |  7 -------
  1 files changed, 0 insertions(+), 7 deletions(-)


diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c
--- a/Modules/posixmodule.c
+++ b/Modules/posixmodule.c
@@ -11865,7 +11865,6 @@
         }
     }
 
-    Py_CLEAR(iterator->path.object);
     path_cleanup(&iterator->path);
 
     /* Restore the saved exception. */
@@ -11969,12 +11968,6 @@
                                      path_converter, &iterator->path))
         goto error;
 
-    /* path_converter doesn't keep path.object around, so do it
-       manually for the lifetime of the iterator here (the refcount
-       is decremented in ScandirIterator_dealloc)
-    */
-    Py_XINCREF(iterator->path.object);
-
 #ifdef MS_WINDOWS
     iterator->first_time = 1;
 

-- 
Repository URL: https://hg.python.org/cpython


More information about the Python-checkins mailing list