[Python-checkins] bpo-32013: _pickle: Add missing Py_DECREF in error case in fast_save_enter() (#4384)

Serhiy Storchaka webhook-mailer at python.org
Mon Nov 13 02:50:19 EST 2017


https://github.com/python/cpython/commit/f76231f89a7231fd486b37f728fbb4aab389e4d7
commit: f76231f89a7231fd486b37f728fbb4aab389e4d7
branch: master
author: Mat M <mathew1800 at gmail.com>
committer: Serhiy Storchaka <storchaka at gmail.com>
date: 2017-11-13T09:50:16+02:00
summary:

bpo-32013: _pickle: Add missing Py_DECREF in error case in fast_save_enter() (#4384)

files:
M Modules/_pickle.c

diff --git a/Modules/_pickle.c b/Modules/_pickle.c
index b71fb9350e6..4b7f1ed66b3 100644
--- a/Modules/_pickle.c
+++ b/Modules/_pickle.c
@@ -1777,8 +1777,10 @@ fast_save_enter(PicklerObject *self, PyObject *obj)
             }
         }
         key = PyLong_FromVoidPtr(obj);
-        if (key == NULL)
+        if (key == NULL) {
+            self->fast_nesting = -1;
             return 0;
+        }
         if (PyDict_GetItemWithError(self->fast_memo, key)) {
             Py_DECREF(key);
             PyErr_Format(PyExc_ValueError,
@@ -1789,6 +1791,8 @@ fast_save_enter(PicklerObject *self, PyObject *obj)
             return 0;
         }
         if (PyErr_Occurred()) {
+            Py_DECREF(key);
+            self->fast_nesting = -1;
             return 0;
         }
         if (PyDict_SetItem(self->fast_memo, key, Py_None) < 0) {



More information about the Python-checkins mailing list