[Python-checkins] bpo-31806: Use _PyTime_ROUND_TIMEOUT for the timeout argument parsing in more functions (#4026)
Serhiy Storchaka
webhook-mailer at python.org
Wed Oct 18 03:13:12 EDT 2017
https://github.com/python/cpython/commit/59af94fa61bf90adbe624508e909b5d6ef6e8464
commit: 59af94fa61bf90adbe624508e909b5d6ef6e8464
branch: master
author: Pablo Galindo <Pablogsal at gmail.com>
committer: Serhiy Storchaka <storchaka at gmail.com>
date: 2017-10-18T10:13:09+03:00
summary:
bpo-31806: Use _PyTime_ROUND_TIMEOUT for the timeout argument parsing in more functions (#4026)
Fix timeout rounding in time.sleep(), threading.Lock.acquire() and
socket.socket.settimeout() to round correctly negative timeouts between -1.0 and
0.0. The functions now block waiting for events as expected. Previously, the
call was incorrectly non-blocking.
files:
A Misc/NEWS.d/next/Library/2017-10-17-23-27-03.bpo-31806.TzphdL.rst
M Modules/_threadmodule.c
M Modules/socketmodule.c
M Modules/timemodule.c
diff --git a/Misc/NEWS.d/next/Library/2017-10-17-23-27-03.bpo-31806.TzphdL.rst b/Misc/NEWS.d/next/Library/2017-10-17-23-27-03.bpo-31806.TzphdL.rst
new file mode 100644
index 00000000000..941e77d5197
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2017-10-17-23-27-03.bpo-31806.TzphdL.rst
@@ -0,0 +1,4 @@
+Fix timeout rounding in time.sleep(), threading.Lock.acquire() and
+socket.socket.settimeout() to round correctly negative timeouts between -1.0 and
+0.0. The functions now block waiting for events as expected. Previously, the
+call was incorrectly non-blocking. Patch by Pablo Galindo.
diff --git a/Modules/_threadmodule.c b/Modules/_threadmodule.c
index 2657a1fc68d..72df78f9ccc 100644
--- a/Modules/_threadmodule.c
+++ b/Modules/_threadmodule.c
@@ -104,7 +104,7 @@ lock_acquire_parse_args(PyObject *args, PyObject *kwds,
if (timeout_obj
&& _PyTime_FromSecondsObject(timeout,
- timeout_obj, _PyTime_ROUND_CEILING) < 0)
+ timeout_obj, _PyTime_ROUND_TIMEOUT) < 0)
return -1;
if (!blocking && *timeout != unset_timeout ) {
@@ -122,7 +122,7 @@ lock_acquire_parse_args(PyObject *args, PyObject *kwds,
else if (*timeout != unset_timeout) {
_PyTime_t microseconds;
- microseconds = _PyTime_AsMicroseconds(*timeout, _PyTime_ROUND_CEILING);
+ microseconds = _PyTime_AsMicroseconds(*timeout, _PyTime_ROUND_TIMEOUT);
if (microseconds >= PY_TIMEOUT_MAX) {
PyErr_SetString(PyExc_OverflowError,
"timeout value is too large");
diff --git a/Modules/socketmodule.c b/Modules/socketmodule.c
index 5df9d014c35..0758f9bd409 100644
--- a/Modules/socketmodule.c
+++ b/Modules/socketmodule.c
@@ -2539,7 +2539,7 @@ socket_parse_timeout(_PyTime_t *timeout, PyObject *timeout_obj)
}
if (_PyTime_FromSecondsObject(timeout,
- timeout_obj, _PyTime_ROUND_CEILING) < 0)
+ timeout_obj, _PyTime_ROUND_TIMEOUT) < 0)
return -1;
if (*timeout < 0) {
@@ -2548,10 +2548,10 @@ socket_parse_timeout(_PyTime_t *timeout, PyObject *timeout_obj)
}
#ifdef MS_WINDOWS
- overflow |= (_PyTime_AsTimeval(*timeout, &tv, _PyTime_ROUND_CEILING) < 0);
+ overflow |= (_PyTime_AsTimeval(*timeout, &tv, _PyTime_ROUND_TIMEOUT) < 0);
#endif
#ifndef HAVE_POLL
- ms = _PyTime_AsMilliseconds(*timeout, _PyTime_ROUND_CEILING);
+ ms = _PyTime_AsMilliseconds(*timeout, _PyTime_ROUND_TIMEOUT);
overflow |= (ms > INT_MAX);
#endif
if (overflow) {
diff --git a/Modules/timemodule.c b/Modules/timemodule.c
index 463f5c55770..b5e168f9ec3 100644
--- a/Modules/timemodule.c
+++ b/Modules/timemodule.c
@@ -245,7 +245,7 @@ static PyObject *
time_sleep(PyObject *self, PyObject *obj)
{
_PyTime_t secs;
- if (_PyTime_FromSecondsObject(&secs, obj, _PyTime_ROUND_CEILING))
+ if (_PyTime_FromSecondsObject(&secs, obj, _PyTime_ROUND_TIMEOUT))
return NULL;
if (secs < 0) {
PyErr_SetString(PyExc_ValueError,
More information about the Python-checkins
mailing list