[Python-checkins] Don't use `where`, it doesn't exist on XP (GH-3330)

Zachary Ware webhook-mailer at python.org
Tue Sep 5 12:34:57 EDT 2017


https://github.com/python/cpython/commit/aa23144d153b9c30fbaf8ba8d2a4d6a668e79417
commit: aa23144d153b9c30fbaf8ba8d2a4d6a668e79417
branch: 2.7
author: Zachary Ware <zachary.ware at gmail.com>
committer: GitHub <noreply at github.com>
date: 2017-09-05T09:34:54-07:00
summary:

Don't use `where`, it doesn't exist on XP (GH-3330)

files:
M PCbuild/get_externals.bat

diff --git a/PCbuild/get_externals.bat b/PCbuild/get_externals.bat
index e83e1d4c9ad..92fc9441727 100644
--- a/PCbuild/get_externals.bat
+++ b/PCbuild/get_externals.bat
@@ -32,8 +32,11 @@ if "%DO_FETCH%"=="false" goto end
 if "%ORG%"=="" (set ORG=python)
 call "%PCBUILD%find_python.bat" "%PYTHON%"
 
-if "%PYTHON%"=="" (
-    where /Q git || echo Python 3.6 could not be found or installed, and git.exe is not on your PATH && exit /B 1
+git 2>&1 > nul
+if ERRORLEVEL 9009 (
+    if "%PYTHON%"=="" (
+        echo Python 3.6 could not be found or installed, and git.exe is not on your PATH && exit /B 1
+    )
 )
 
 echo.Fetching external libraries...



More information about the Python-checkins mailing list