[Python-checkins] [3.6] bpo-30781: IDLE: Fix help button on configdialog (GH-3238) (#3489)

Terry Jan Reedy webhook-mailer at python.org
Sun Sep 10 23:19:38 EDT 2017


https://github.com/python/cpython/commit/4a8b53a2083506ee13ff2eba2c14264f5a7faa91
commit: 4a8b53a2083506ee13ff2eba2c14264f5a7faa91
branch: 3.6
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: Terry Jan Reedy <tjreedy at udel.edu>
date: 2017-09-10T23:19:35-04:00
summary:

[3.6] bpo-30781: IDLE: Fix help button on configdialog (GH-3238) (#3489)

This fixes an omission in the ttk conversion patch for this issue, hence no new news.
Patch by Cheryl Sabella.
(cherry picked from commit 3866d9bbcf808cea98b3d00007f9f246b83858ce)

files:
M Lib/idlelib/configdialog.py

diff --git a/Lib/idlelib/configdialog.py b/Lib/idlelib/configdialog.py
index 604719f0453..683c36e9776 100644
--- a/Lib/idlelib/configdialog.py
+++ b/Lib/idlelib/configdialog.py
@@ -187,12 +187,12 @@ def help(self):
         """Create textview for config dialog help.
 
         Attrbutes accessed:
-            tab_pages
+            note
 
         Methods:
             view_text: Method from textview module.
         """
-        page = self.tab_pages._current_page
+        page = self.note.tab(self.note.select(), option='text').strip()
         view_text(self, title='Help for IDLE preferences',
                  text=help_common+help_pages.get(page, ''))
 
@@ -2104,7 +2104,7 @@ def detach(self):
 [Cancel] only cancels changes made since the last save.
 '''
 help_pages = {
-    'Highlighting': '''
+    'Highlights': '''
 Highlighting:
 The IDLE Dark color theme is new in October 2015.  It can only
 be used with older IDLE releases if it is saved as a custom



More information about the Python-checkins mailing list