[Python-checkins] [3.6] bpo-31448, test_poplib: Fix ResourceWarning (GH-3542) (#3543)
Victor Stinner
webhook-mailer at python.org
Wed Sep 13 09:09:47 EDT 2017
https://github.com/python/cpython/commit/769ddb075ac3a840d473930a12a5b72bfbab366f
commit: 769ddb075ac3a840d473930a12a5b72bfbab366f
branch: 3.6
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: Victor Stinner <victor.stinner at gmail.com>
date: 2017-09-13T06:09:44-07:00
summary:
[3.6] bpo-31448, test_poplib: Fix ResourceWarning (GH-3542) (#3543)
Call POP3.close(), don't close close directly the sock attribute.
(cherry picked from commit d165e14e29b45a22450263722f5c2c386c3a748a)
files:
M Lib/test/test_poplib.py
diff --git a/Lib/test/test_poplib.py b/Lib/test/test_poplib.py
index e5b16dc98a4..6bc97397808 100644
--- a/Lib/test/test_poplib.py
+++ b/Lib/test/test_poplib.py
@@ -483,7 +483,7 @@ def testTimeoutDefault(self):
finally:
socket.setdefaulttimeout(None)
self.assertEqual(pop.sock.gettimeout(), 30)
- pop.sock.close()
+ pop.close()
def testTimeoutNone(self):
self.assertIsNone(socket.getdefaulttimeout())
@@ -493,12 +493,12 @@ def testTimeoutNone(self):
finally:
socket.setdefaulttimeout(None)
self.assertIsNone(pop.sock.gettimeout())
- pop.sock.close()
+ pop.close()
def testTimeoutValue(self):
pop = poplib.POP3(HOST, self.port, timeout=30)
self.assertEqual(pop.sock.gettimeout(), 30)
- pop.sock.close()
+ pop.close()
def test_main():
More information about the Python-checkins
mailing list