[Python-checkins] Call super in Generic.__init_subclass__ (GH-6356)
Miss Islington (bot)
webhook-mailer at python.org
Wed Apr 4 12:51:37 EDT 2018
https://github.com/python/cpython/commit/bd85c9738296cf4a53859ed17e9a6812d2071a21
commit: bd85c9738296cf4a53859ed17e9a6812d2071a21
branch: 3.7
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: GitHub <noreply at github.com>
date: 2018-04-04T09:51:34-07:00
summary:
Call super in Generic.__init_subclass__ (GH-6356)
(cherry picked from commit ee566fe526f3d069aa313578ee81ca6cbc25ff52)
Co-authored-by: Ivan Levkivskyi <levkivskyi at gmail.com>
files:
M Lib/test/test_typing.py
M Lib/typing.py
diff --git a/Lib/test/test_typing.py b/Lib/test/test_typing.py
index 09e39fec45e4..b12e5ea2fb80 100644
--- a/Lib/test/test_typing.py
+++ b/Lib/test/test_typing.py
@@ -1232,6 +1232,25 @@ class B(Generic[S]): ...
class C(List[int], B): ...
self.assertEqual(C.__mro__, (C, list, B, Generic, object))
+ def test_init_subclass_super_called(self):
+ class FinalException(Exception):
+ pass
+
+ class Final:
+ def __init_subclass__(cls, **kwargs) -> None:
+ for base in cls.__bases__:
+ if base is not Final and issubclass(base, Final):
+ raise FinalException(base)
+ super().__init_subclass__(**kwargs)
+ class Test(Generic[T], Final):
+ pass
+ with self.assertRaises(FinalException):
+ class Subclass(Test):
+ pass
+ with self.assertRaises(FinalException):
+ class Subclass(Test[int]):
+ pass
+
def test_nested(self):
G = Generic
diff --git a/Lib/typing.py b/Lib/typing.py
index 510574c413e3..3ac3b9382262 100644
--- a/Lib/typing.py
+++ b/Lib/typing.py
@@ -850,6 +850,7 @@ def __class_getitem__(cls, params):
return _GenericAlias(cls, params)
def __init_subclass__(cls, *args, **kwargs):
+ super().__init_subclass__(*args, **kwargs)
tvars = []
if '__orig_bases__' in cls.__dict__:
error = Generic in cls.__orig_bases__
More information about the Python-checkins
mailing list