[Python-checkins] Minor code clean-up. Don't alter the input vector. Use variables instead. GH-8748
Raymond Hettinger
webhook-mailer at python.org
Sun Aug 12 17:18:59 EDT 2018
https://github.com/python/cpython/commit/a47f394af83c4bc29fac65c31e04091f87b98b35
commit: a47f394af83c4bc29fac65c31e04091f87b98b35
branch: master
author: Raymond Hettinger <rhettinger at users.noreply.github.com>
committer: GitHub <noreply at github.com>
date: 2018-08-12T14:18:56-07:00
summary:
Minor code clean-up. Don't alter the input vector. Use variables instead. GH-8748
files:
M Modules/mathmodule.c
diff --git a/Modules/mathmodule.c b/Modules/mathmodule.c
index ab49dcef2884..2d483afff54d 100644
--- a/Modules/mathmodule.c
+++ b/Modules/mathmodule.c
@@ -2056,7 +2056,7 @@ the *vec* is a NaN.
static inline double
vector_norm(Py_ssize_t n, double *vec, double max, int found_nan)
{
- double x, csum = 0.0, oldcsum, frac = 0.0;
+ double x, csum = 0.0, oldcsum, frac = 0.0, last;
Py_ssize_t i;
if (Py_IS_INFINITY(max)) {
@@ -2069,12 +2069,13 @@ vector_norm(Py_ssize_t n, double *vec, double max, int found_nan)
return 0.0;
}
assert(n > 0);
+ last = vec[n-1];
for (i=0 ; i < n-1 ; i++) {
x = vec[i];
assert(Py_IS_FINITE(x) && x >= 0.0 && x <= max);
if (x == max) {
- x = vec[n-1];
- vec[n-1] = max;
+ x = last;
+ last = max;
}
x /= max;
x = x*x - frac;
@@ -2082,7 +2083,7 @@ vector_norm(Py_ssize_t n, double *vec, double max, int found_nan)
csum += x;
frac = (csum - oldcsum) - x;
}
- assert(vec[n-1] == max);
+ assert(last == max);
csum += 1.0 - frac;
return max * sqrt(csum);
}
More information about the Python-checkins
mailing list