[Python-checkins] bpo-34456: pickle: Add missing NULL check to save_global(). (GH-8851)

[Serhiy Storchaka]

https://github.com/python/cpython/commit/f8c06b028036e50596e75d4c9f6b27ba05133efe
commit: f8c06b028036e50596e75d4c9f6b27ba05133efe
branch: master
author: Alexey Izbyshev <izbyshev at ispras.ru>
committer: Serhiy Storchaka <storchaka at gmail.com>
date: 2018-08-22T07:51:25+03:00
summary:

bpo-34456: pickle: Add missing NULL check to save_global(). (GH-8851)

Reported by Svace static analyzer.

files:
M Modules/_pickle.c

diff --git a/Modules/_pickle.c b/Modules/_pickle.c
index ea778c763520..517c99e1746b 100644
--- a/Modules/_pickle.c
+++ b/Modules/_pickle.c
@@ -3454,6 +3454,8 @@ save_global(PicklerObject *self, PyObject *obj, PyObject *name)
             PickleState *st = _Pickle_GetGlobalState();
             PyObject *reduce_value = Py_BuildValue("(O(OO))",
                                         st->getattr, parent, lastname);
+            if (reduce_value == NULL)
+                goto error;
             status = save_reduce(self, reduce_value, NULL);
             Py_DECREF(reduce_value);
             if (status < 0)