[Python-checkins] closes bpo-34474: Python/bltinmodule.c: Add missing NULL check in builtin_sum_impl() (GH-8872)

Benjamin Peterson webhook-mailer at python.org
Fri Aug 24 00:27:55 EDT 2018


https://github.com/python/cpython/commit/2b824b2538c4a5f9f520c5de8a1eae5a0c181a94
commit: 2b824b2538c4a5f9f520c5de8a1eae5a0c181a94
branch: master
author: Alexey Izbyshev <izbyshev at ispras.ru>
committer: Benjamin Peterson <benjamin at python.org>
date: 2018-08-23T21:27:52-07:00
summary:

closes bpo-34474: Python/bltinmodule.c: Add missing NULL check in builtin_sum_impl() (GH-8872)

Reported by Svace static analyzer.

files:
M Python/bltinmodule.c

diff --git a/Python/bltinmodule.c b/Python/bltinmodule.c
index 4b12048f9d56..8aa1ba01d659 100644
--- a/Python/bltinmodule.c
+++ b/Python/bltinmodule.c
@@ -2401,6 +2401,11 @@ builtin_sum_impl(PyObject *module, PyObject *iterable, PyObject *start)
                 }
             }
             result = PyFloat_FromDouble(f_result);
+            if (result == NULL) {
+                Py_DECREF(item);
+                Py_DECREF(iter);
+                return NULL;
+            }
             temp = PyNumber_Add(result, item);
             Py_DECREF(result);
             Py_DECREF(item);



More information about the Python-checkins mailing list