[Python-checkins] Ignore importlib.h for automatic review requests from the import team. (GH-5087)

Brett Cannon webhook-mailer at python.org
Wed Jan 3 14:32:31 EST 2018


https://github.com/python/cpython/commit/811b2878dfc68dc3ecd81fb4b370c6e1f9ec69c2
commit: 811b2878dfc68dc3ecd81fb4b370c6e1f9ec69c2
branch: master
author: Brett Cannon <brettcannon at users.noreply.github.com>
committer: GitHub <noreply at github.com>
date: 2018-01-03T11:32:22-08:00
summary:

Ignore importlib.h for automatic review requests from the import team. (GH-5087)

Otherwise the import team gets flagged for reviews any time the bytecode for
importlib.h changes (e.g new bytecode, optimizations, etc.).

files:
M .github/CODEOWNERS

diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
index d751a918d0d..b42e1c93d8f 100644
--- a/.github/CODEOWNERS
+++ b/.github/CODEOWNERS
@@ -14,8 +14,13 @@
 **/*hashlib*                  @python/crypto-team
 **/*pyhash*                   @python/crypto-team
 
-# Import (including importlib)
-**/*import*                   @python/import-team
+# Import (including importlib).
+# Ignoring importlib.h so as to not get flagged on
+# all pull requests that change the the emitted
+# bytecode.
+**/*import*.c                 @python/import-team
+**/*import*.py                @python/import-team
+
 
 # SSL
 **/*ssl*                      @python/crypto-team



More information about the Python-checkins mailing list