[Python-checkins] bpo-34136: Make test_do_not_recreate_annotations more lenient. (GH-8437)

Serhiy Storchaka webhook-mailer at python.org
Tue Jul 24 08:05:31 EDT 2018


https://github.com/python/cpython/commit/c206f0d1375fab7b58c19a6be3e68e316f718c66
commit: c206f0d1375fab7b58c19a6be3e68e316f718c66
branch: master
author: Serhiy Storchaka <storchaka at gmail.com>
committer: GitHub <noreply at github.com>
date: 2018-07-24T15:05:28+03:00
summary:

bpo-34136: Make test_do_not_recreate_annotations more lenient. (GH-8437)

files:
M Lib/test/test_opcodes.py

diff --git a/Lib/test/test_opcodes.py b/Lib/test/test_opcodes.py
index 20de3867bfae..b2a22861880f 100644
--- a/Lib/test/test_opcodes.py
+++ b/Lib/test/test_opcodes.py
@@ -42,14 +42,13 @@ def test_use_existing_annotations(self):
         self.assertEqual(ns['__annotations__'], {'x': int, 1: 2})
 
     def test_do_not_recreate_annotations(self):
-        annotations = {}
         # Don't rely on the existence of the '__annotations__' global.
-        with support.swap_item(globals(), '__annotations__', annotations):
+        with support.swap_item(globals(), '__annotations__', {}):
+            del globals()['__annotations__']
             class C:
                 del __annotations__
-                x: int  # Updates the '__annotations__' global.
-        self.assertIn('x', annotations)
-        self.assertIs(annotations['x'], int)
+                with self.assertRaises(NameError):
+                    x: int
 
     def test_raise_class_exceptions(self):
 



More information about the Python-checkins mailing list