[Python-checkins] bpo-33904: In IDLE's rstrip, rename class RstripExtension as Rstrip (GH-7811)

Miss Islington (bot) webhook-mailer at python.org
Wed Jun 20 11:56:33 EDT 2018


https://github.com/python/cpython/commit/b0f352680e73a374748994d383f591f2e4702669
commit: b0f352680e73a374748994d383f591f2e4702669
branch: 3.7
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: GitHub <noreply at github.com>
date: 2018-06-20T08:56:22-07:00
summary:

bpo-33904:  In IDLE's rstrip, rename class RstripExtension as Rstrip (GH-7811)

(cherry picked from commit 9bb92235f6272b28d59fcbd04f101fdc6b1bbc50)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్ రెడ్డి తాటిపర్తి) <srinivasreddy at users.noreply.github.com>

files:
A Misc/NEWS.d/next/IDLE/2018-06-20-12-40-54.bpo-33904.qm0eCu.rst
M Lib/idlelib/editor.py
M Lib/idlelib/idle_test/test_rstrip.py
M Lib/idlelib/rstrip.py

diff --git a/Lib/idlelib/editor.py b/Lib/idlelib/editor.py
index f5a091860ec6..b46316569d05 100644
--- a/Lib/idlelib/editor.py
+++ b/Lib/idlelib/editor.py
@@ -58,7 +58,7 @@ class EditorWindow(object):
     from idlelib.codecontext import CodeContext
     from idlelib.paragraph import FormatParagraph
     from idlelib.parenmatch import ParenMatch
-    from idlelib.rstrip import RstripExtension
+    from idlelib.rstrip import Rstrip
     from idlelib.zoomheight import ZoomHeight
 
     filesystemencoding = sys.getfilesystemencoding()  # for file names
@@ -310,7 +310,7 @@ def __init__(self, flist=None, filename=None, key=None, root=None):
         scriptbinding = ScriptBinding(self)
         text.bind("<<check-module>>", scriptbinding.check_module_event)
         text.bind("<<run-module>>", scriptbinding.run_module_event)
-        text.bind("<<do-rstrip>>", self.RstripExtension(self).do_rstrip)
+        text.bind("<<do-rstrip>>", self.Rstrip(self).do_rstrip)
         ctip = self.Calltip(self)
         text.bind("<<try-open-calltip>>", ctip.try_open_calltip_event)
         #refresh-calltip must come after paren-closed to work right
diff --git a/Lib/idlelib/idle_test/test_rstrip.py b/Lib/idlelib/idle_test/test_rstrip.py
index 9ef1320eefba..2bc7c6f035e9 100644
--- a/Lib/idlelib/idle_test/test_rstrip.py
+++ b/Lib/idlelib/idle_test/test_rstrip.py
@@ -9,7 +9,7 @@ class rstripTest(unittest.TestCase):
     def test_rstrip_line(self):
         editor = Editor()
         text = editor.text
-        do_rstrip = rstrip.RstripExtension(editor).do_rstrip
+        do_rstrip = rstrip.Rstrip(editor).do_rstrip
 
         do_rstrip()
         self.assertEqual(text.get('1.0', 'insert'), '')
@@ -27,7 +27,7 @@ def test_rstrip_multiple(self):
         #from tkinter import Tk
         #editor = Editor(root=Tk())
         text = editor.text
-        do_rstrip = rstrip.RstripExtension(editor).do_rstrip
+        do_rstrip = rstrip.Rstrip(editor).do_rstrip
 
         original = (
             "Line with an ending tab    \n"
diff --git a/Lib/idlelib/rstrip.py b/Lib/idlelib/rstrip.py
index b845d809d315..f93b5e8fc200 100644
--- a/Lib/idlelib/rstrip.py
+++ b/Lib/idlelib/rstrip.py
@@ -1,6 +1,6 @@
 'Provides "Strip trailing whitespace" under the "Format" menu.'
 
-class RstripExtension:
+class Rstrip:
 
     def __init__(self, editwin):
         self.editwin = editwin
diff --git a/Misc/NEWS.d/next/IDLE/2018-06-20-12-40-54.bpo-33904.qm0eCu.rst b/Misc/NEWS.d/next/IDLE/2018-06-20-12-40-54.bpo-33904.qm0eCu.rst
new file mode 100644
index 000000000000..efed2379b4bf
--- /dev/null
+++ b/Misc/NEWS.d/next/IDLE/2018-06-20-12-40-54.bpo-33904.qm0eCu.rst
@@ -0,0 +1 @@
+IDLE: In rstrip, rename class RstripExtension as Rstrip



More information about the Python-checkins mailing list