[Python-checkins] bpo-33951: IDLE test_configdialog: call page.update in setUpClass (GH-7892)

Miss Islington (bot) webhook-mailer at python.org
Sun Jun 24 16:55:42 EDT 2018


https://github.com/python/cpython/commit/b3bac968fe5beb6e6e334903519b2c8ce5bb366b
commit: b3bac968fe5beb6e6e334903519b2c8ce5bb366b
branch: 3.7
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: GitHub <noreply at github.com>
date: 2018-06-24T13:55:39-07:00
summary:

bpo-33951: IDLE test_configdialog: call page.update in setUpClass (GH-7892)


This avoids a failure in at least one case when running only a single
test method rather than all tests in the module.

The issue came up when testing the following on Windows 10 Pro 64-bit:
HighPageTest.test_highlight_target_text_mouse
(cherry picked from commit 2af9f5d334eeca588eeee87d177faf0012c63a03)

Co-authored-by: Tal Einat <taleinat+github at gmail.com>

files:
M Lib/idlelib/idle_test/test_configdialog.py

diff --git a/Lib/idlelib/idle_test/test_configdialog.py b/Lib/idlelib/idle_test/test_configdialog.py
index fe712b18a5e0..dbfcd01c63ea 100644
--- a/Lib/idlelib/idle_test/test_configdialog.py
+++ b/Lib/idlelib/idle_test/test_configdialog.py
@@ -60,6 +60,7 @@ def setUpClass(cls):
         page = cls.page = dialog.fontpage
         dialog.note.select(page)
         page.set_samples = Func()  # Mask instance method.
+        page.update()
 
     @classmethod
     def tearDownClass(cls):
@@ -210,6 +211,7 @@ class IndentTest(unittest.TestCase):
     @classmethod
     def setUpClass(cls):
         cls.page = dialog.fontpage
+        cls.page.update()
 
     def test_load_tab_cfg(self):
         d = self.page
@@ -240,6 +242,7 @@ def setUpClass(cls):
         page.paint_theme_sample = Func()
         page.set_highlight_target = Func()
         page.set_color_sample = Func()
+        page.update()
 
     @classmethod
     def tearDownClass(cls):
@@ -1085,6 +1088,7 @@ def setUpClass(cls):
         dialog.note.select(page)
         page.set = page.set_add_delete_state = Func()
         page.upc = page.update_help_changes = Func()
+        page.update()
 
     @classmethod
     def tearDownClass(cls):



More information about the Python-checkins mailing list