[Python-checkins] Fix strncpy warning with gcc 8 (#5840)

Xiang Zhang webhook-mailer at python.org
Tue Mar 6 05:34:39 EST 2018


https://github.com/python/cpython/commit/efd2bac1564f8141a4eab1bf8779b412974b8d69
commit: efd2bac1564f8141a4eab1bf8779b412974b8d69
branch: master
author: Siddhesh Poyarekar <siddhesh.poyarekar at gmail.com>
committer: Xiang Zhang <angwerzx at 126.com>
date: 2018-03-06T18:34:35+08:00
summary:

Fix strncpy warning with gcc 8 (#5840)

The length in strncpy is one char too short and as a result it leads
to a build warning with gcc 8.  Comment out the strncpy since the
interpreter aborts immediately after anyway.

files:
M Python/pystrtod.c

diff --git a/Python/pystrtod.c b/Python/pystrtod.c
index 9bf936386210..601f7c691edf 100644
--- a/Python/pystrtod.c
+++ b/Python/pystrtod.c
@@ -1060,8 +1060,8 @@ format_float_short(double d, char format_code,
         else {
             /* shouldn't get here: Gay's code should always return
                something starting with a digit, an 'I',  or 'N' */
-            strncpy(p, "ERR", 3);
-            /* p += 3; */
+            /* strncpy(p, "ERR", 3);
+               p += 3; */
             Py_UNREACHABLE();
         }
         goto exit;



More information about the Python-checkins mailing list